Implement restart-required message on Linux.

Implement restart-required message on Linux.

When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG=641611
Committed: https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf
Cr-Commit-Position: refs/heads/master@{#424288}

[waffles, 2016-09-27 17:46:12]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 17:46:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-09-27 17:52:45]

waffles@chromium.org changed reviewers:
+ bauerb@chromium.org, sorin@chromium.org, thestig@chromium.org,
wfh@chromium.org

[waffles, 2016-09-27 17:52:46]

Hi all, PTAL at this UI polish issue around just-in-time Flash updates on Linux,
where we require a browser restart in order to pick up the new implementation of
Flash due to sandboxing issues.

The string has been approved by hwi@ and ainslie@.

[Sorin Jianu, 2016-09-27 17:59:40]

lgtm

Thank you!

https://codereview.chromium.org/2370923005/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2370923005/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:878: base::string16
accname_app = l10n_util::GetStringUTF16(IDS_ACCNAME_APP);
maybe const?

[Greg K, 2016-09-27 18:14:09]

On 2016/09/27 17:52:46, waffles wrote:
> Hi all, PTAL at this UI polish issue around just-in-time Flash updates on
Linux,
> where we require a browser restart in order to pick up the new implementation
of
> Flash due to sandboxing issues.
> 
> The string has been approved by hwi@ and ainslie@.

lgtm, thanks!

[commit-bot: I haz the power, 2016-09-27 18:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:38:01]

Dry run: This issue passed the CQ dry run.

[Will Harris, 2016-09-27 22:39:57]

can you update the first line of the CL description so it appears nicely in
commit history? Thanks!

[waffles, 2016-09-27 22:44:36]

Description was changed from

==========
When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG=641611
==========

to

==========
Implement restart-required message on Linux.

When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG=641611
==========

[waffles, 2016-09-27 22:44:46]

On 2016/09/27 22:39:57, Will Harris wrote:
> can you update the first line of the CL description so it appears nicely in
> commit history? Thanks!

Done.

[waffles, 2016-09-27 22:54:11]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[waffles, 2016-09-27 22:54:19]

https://codereview.chromium.org/2370923005/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2370923005/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:878: base::string16
accname_app = l10n_util::GetStringUTF16(IDS_ACCNAME_APP);
On 2016/09/27 17:59:40, Sorin Jianu wrote:
> maybe const?

Done.

[commit-bot: I haz the power, 2016-09-27 22:54:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:44:56]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-09-28 08:44:01]

lgtm

[waffles, 2016-10-10 18:20:00]

wfh, thestig: ping

(wfh: welcome back!)

[Will Harris, 2016-10-10 18:25:06]

lgtm for the chrome/common/render_messages.h

[Lei Zhang, 2016-10-10 18:29:13]

https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:7186: +        Restart <ph
name="ACCNAME_APP">$1<ex>Chrome</ex></ph> to enable <ph
name="PLUGIN_NAME">$2<ex>Flash</ex></ph>
Is $1 always going to be "Chrome" or "Chromium" ?

Can this go in chromium_strings.grd / google_chrome_strings.grd instead?

[waffles, 2016-10-10 21:45:44]

On 2016/10/10 18:29:13, Lei Zhang wrote:
>
https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:7186: +        Restart <ph
> name="ACCNAME_APP">$1<ex>Chrome</ex></ph> to enable <ph
> name="PLUGIN_NAME">$2<ex>Flash</ex></ph>
> Is $1 always going to be "Chrome" or "Chromium" ?
> 
> Can this go in chromium_strings.grd / google_chrome_strings.grd instead?

I think so? But all the other plugin placeholder strings are in
generated_resources.grd, so I'm hesitant to break the pattern, in case there is
something I don't understand.

[Lei Zhang, 2016-10-10 21:52:11]

On 2016/10/10 21:45:44, waffles wrote:
> On 2016/10/10 18:29:13, Lei Zhang wrote:
> >
>
https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
> > File chrome/app/generated_resources.grd (right):
> > 
> >
>
https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
> > chrome/app/generated_resources.grd:7186: +        Restart <ph
> > name="ACCNAME_APP">$1<ex>Chrome</ex></ph> to enable <ph
> > name="PLUGIN_NAME">$2<ex>Flash</ex></ph>
> > Is $1 always going to be "Chrome" or "Chromium" ?
> > 
> > Can this go in chromium_strings.grd / google_chrome_strings.grd instead?
> 
> I think so? But all the other plugin placeholder strings are in
> generated_resources.grd, so I'm hesitant to break the pattern, in case there
is
> something I don't understand.

Do any of the other strings have the product name in them?

See https://bugs.chromium.org/p/chromium/issues/detail?id=111425

[waffles, 2016-10-10 22:47:46]

On 2016/10/10 21:52:11, Lei Zhang wrote:
> On 2016/10/10 21:45:44, waffles wrote:
> > On 2016/10/10 18:29:13, Lei Zhang wrote:
> > >
> >
>
https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
> > > File chrome/app/generated_resources.grd (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2370923005/diff/20001/chrome/app/generated_re...
> > > chrome/app/generated_resources.grd:7186: +        Restart <ph
> > > name="ACCNAME_APP">$1<ex>Chrome</ex></ph> to enable <ph
> > > name="PLUGIN_NAME">$2<ex>Flash</ex></ph>
> > > Is $1 always going to be "Chrome" or "Chromium" ?
> > > 
> > > Can this go in chromium_strings.grd / google_chrome_strings.grd instead?
> > 
> > I think so? But all the other plugin placeholder strings are in
> > generated_resources.grd, so I'm hesitant to break the pattern, in case there
> is
> > something I don't understand.
> 
> Do any of the other strings have the product name in them?
> 
> See https://bugs.chromium.org/p/chromium/issues/detail?id=111425

Ah, I see. Done.

[Lei Zhang, 2016-10-10 22:57:56]

lgtm

[waffles, 2016-10-10 23:02:07]

The CQ bit was checked by waffles@chromium.org

[waffles, 2016-10-10 23:02:08]

The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org,
kerrnel@chromium.org, bauerb@chromium.org, wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2370923005/#ps40001
(title: "Through #22 & sync")

[commit-bot: I haz the power, 2016-10-10 23:02:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 23:42:44]

Description was changed from

==========
Implement restart-required message on Linux.

When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG=641611
==========

to

==========
Implement restart-required message on Linux.

When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG=641611
==========

[commit-bot: I haz the power, 2016-10-10 23:42:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-10 23:47:52]

Description was changed from

==========
Implement restart-required message on Linux.

When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG=641611
==========

to

==========
Implement restart-required message on Linux.

When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG=641611

Committed: https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf
Cr-Commit-Position: refs/heads/master@{#424288}
==========

[commit-bot: I haz the power, 2016-10-10 23:47:53]

Patchset 3 (id:??) landed as
https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf
Cr-Commit-Position: refs/heads/master@{#424288}