Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Issue 2370923004: Change webkitpy.style.main_unittest to use LoggingTestCase. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change webkitpy.style.main_unittest to use LoggingTestCase. In general, LoggingTestCase is the base test case class that's used to support asserting that certain messages were logged. webkitpy.style.main_unittest was the only module that directly uses the helper LogTesting class. This is a minor clean-up CL. Committed: https://crrev.com/43acc2053636e3b959b6769020f1a18b7137ffd3 Cr-Commit-Position: refs/heads/master@{#421326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/style/main_unittest.py View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
qyearsley
4 years, 2 months ago (2016-09-27 17:15:43 UTC) #3
jeffcarp
On 2016/09/27 at 17:15:43, qyearsley wrote: > lgtm
4 years, 2 months ago (2016-09-27 20:37:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370923004/1
4 years, 2 months ago (2016-09-27 20:45:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 20:50:29 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 20:53:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43acc2053636e3b959b6769020f1a18b7137ffd3
Cr-Commit-Position: refs/heads/master@{#421326}

Powered by Google App Engine
This is Rietveld 408576698