Issue 2370923002: Do not overwrite tab_state0 during multi-instance migration

Issue 2370923002: Do not overwrite tab_state0 during multi-instance migration (Closed)

Created:
4 years, 2 months ago by Theresa

Modified:
4 years, 2 months ago

Reviewers:
Ted C, Peter Wen, Steven Holte

CC:
chromium-reviews, asvitkine+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Do not overwrite tab_state0 during multi-instance migration During multi-instance migration, if tab_state0 already exists, do not overwrite it by renaming tab_state. tab_state0 should not already exist when multi-instance migration is run, but if it does and it is overwritten then users may lose tabs. BUG=649384 TBR=tedchoc@chromium.org, wnwen@chromium.org, holte@chromium.org Review-Url: https://codereview.chromium.org/2360183003 Cr-Commit-Position: refs/heads/master@{#420542} Committed: https://chromium.googlesource.com/chromium/src/+/272420fed3f1a6933c7bff279ef2ea78e57367ef

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -9 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabbedModeTabPersistencePolicy.java	View	3 chunks	+26 lines, -9 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/MultiInstanceMigrationTest.java	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Theresa

4 years, 2 months ago (2016-09-26 18:32:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
272420fed3f1a6933c7bff279ef2ea78e57367ef (presubmit successful).