Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2370913003: [Telemetry] Disable long running backgrounded gmail system health test on webview. (Closed)

Created:
4 years, 2 months ago by rnephew (Reviews Here)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Disable long running backgrounded gmail system health test on webview. Webview does not have tabs so it cannot be backgrounded in the same way as other browser types. BUG=650458 Committed: https://crrev.com/9a0e7edd2376bba70eee655a40f46de4d255b14a Cr-Commit-Position: refs/heads/master@{#421244}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/perf/page_sets/system_health/long_running_stories.py View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rnephew (Reviews Here)
4 years, 2 months ago (2016-09-27 15:48:49 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/2370913003/diff/1/tools/perf/page_sets/system_health/long_running_stories.py File tools/perf/page_sets/system_health/long_running_stories.py (right): https://codereview.chromium.org/2370913003/diff/1/tools/perf/page_sets/system_health/long_running_stories.py#newcode89 tools/perf/page_sets/system_health/long_running_stories.py:89: @benchmark.Disabled('android-webview') Can you add reason as comment?
4 years, 2 months ago (2016-09-27 15:59:54 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/2370913003/diff/1/tools/perf/page_sets/system_health/long_running_stories.py File tools/perf/page_sets/system_health/long_running_stories.py (right): https://codereview.chromium.org/2370913003/diff/1/tools/perf/page_sets/system_health/long_running_stories.py#newcode89 tools/perf/page_sets/system_health/long_running_stories.py:89: @benchmark.Disabled('android-webview') On 2016/09/27 15:59:53, nednguyen wrote: > Can you ...
4 years, 2 months ago (2016-09-27 16:03:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370913003/20001
4 years, 2 months ago (2016-09-27 16:03:30 UTC) #7
mikecase (-- gone --)
lgtm
4 years, 2 months ago (2016-09-27 16:24:23 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 17:16:27 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:18:28 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a0e7edd2376bba70eee655a40f46de4d255b14a
Cr-Commit-Position: refs/heads/master@{#421244}

Powered by Google App Engine
This is Rietveld 408576698