Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2370853004: Fix bug effectively stating that 1e8 is an integer literal, not a double. (Closed)

Created:
4 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 2 months ago
Reviewers:
floitsch, eernst
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug effectively stating that 1e8 is an integer literal, not a double. Fix typo in spec - uses `/` when intending division by zero error. Fixes issues #26053, #27279 BUG= http://dartbug.com/26053, http://dartbug.com/27279 R=eernst@google.com, floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/debbf6822376aa660e289f7e28e379ea9c56ed47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M docs/language/dartLangSpec.tex View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
4 years, 2 months ago (2016-09-27 11:56:55 UTC) #2
floitsch
LGTM.
4 years, 2 months ago (2016-09-27 11:58:19 UTC) #4
eernst
lgtm
4 years, 2 months ago (2016-09-27 12:00:58 UTC) #5
Lasse Reichstein Nielsen
4 years, 2 months ago (2016-09-28 07:51:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
debbf6822376aa660e289f7e28e379ea9c56ed47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698