Site Settings Desktop: Only show Remove action if filter hasn't removed all.

chrome/browser/resources/settings/site_settings/site_data.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-data' handles showing the local storage summary list for all sites.
  */
 
 Polymer({
@@ skipping 56 matching lines @@
   showItem_: function(item) {
     if (this.filterString_.length == 0)
       return true;
     return item.site.indexOf(this.filterString_) > -1;
   },
 
   /** @private */
   onSearchChanged_: function(e) {
     this.filterString_ = e.detail;
     this.$.list.render();
+
+    // There seems to be a bug in renderedItemCount where it is always 0 after

[tommycli, 2016/09/26 23:01:34]

why move this code from the computed binding?

Wouldn't this break now when this.sites is updated?

[Finnur, 2016/09/27 14:14:34]

Good question. I tried both ways before and this is the one that worked. Your
suggestion, however, prompted me to try the other way again and this time it not
only worked but also means less code, avoids the bug mentioned in the comment
and there's even no need to update the externs.

Win win win situation. :)

Thanks for suggesting! :)

+    // the list has been rendered initially (with no filter string applied), but
+    // then renderedItemCount matches the total |sites| count anyway.
+    if (this.filterString_ == '')
+      this.$.remove.hidden = this.sites.length == 0;
+    else
+      this.$.remove.hidden = this.$.list['renderedItemCount'] == 0;

[tommycli, 2016/09/26 23:01:34]

list.renderedItemCount?

[Dan Beam, 2016/09/27 00:12:27]

this is why:
https://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compil...

finnur@: I think you just need to cast to /** @type {DomRepeatElement}
*/(this.$.list) and I need to add that property to Polymer's externs:
https://github.com/google/closure-compiler/blob/master/contrib/externs/polyme...

[Finnur, 2016/09/27 14:14:34]

Yup. Dan hit the nail on the head, but it is all moot now anyway.

   },
 
   /**
-   * Returns whether remove all should be shown.
-   * @param {!Array<!CookieDataSummaryItem>} sites The sites list to use to
-   *     determine whether the button should be visible.
-   * @private
-   */
-  removeAllIsVisible_: function(sites) {
-    return sites.length > 0;
-  },
-
-  /**
    * Returns the string to use for the Remove label.
    * @return {!string} filterString The current filter string.
    * @private
    */
   computeRemoveLabel_: function(filterString) {
     if (filterString.length == 0)
       return loadTimeData.getString('siteSettingsCookieRemoveAll');
     return loadTimeData.getString('siteSettingsCookieRemoveAllShown');
   },
 
@@ skipping 82 matching lines @@
     this.shadowRoot.appendChild(dialog);
 
     var node = this.treeNodes_.fetchNodeById(event.model.item.id, false);
     dialog.open(node);
 
     dialog.addEventListener('close', function(event) {
       dialog.remove();
     });
   },
 });