Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2532)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2370833002: Replace ClosedWorld.backend with ClosedWorld.backendClasses (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 4bcffaed7e3cfbb4cd355f1acf5860af78935faa..0899d1b54fb23e3009924f3733250500ebaaffdb 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -11,7 +11,12 @@ import 'package:js_runtime/shared/embedded_names.dart' as embeddedNames;
import '../closure.dart';
import '../common.dart';
import '../common/backend_api.dart'
- show Backend, ImpactTransformer, ForeignResolver, NativeRegistry;
+ show
+ Backend,
+ BackendClasses,
+ ImpactTransformer,
+ ForeignResolver,
+ NativeRegistry;
import '../common/codegen.dart' show CodegenImpact, CodegenWorkItem;
import '../common/names.dart' show Identifiers, Selectors, Uris;
import '../common/registry.dart' show Registry;
@@ -591,6 +596,7 @@ class JavaScriptBackend extends Backend {
final BackendHelpers helpers;
final BackendImpacts impacts;
+ BackendClasses backendClasses;
final JSFrontendAccess frontend;
@@ -630,6 +636,7 @@ class JavaScriptBackend extends Backend {
functionCompiler =
new SsaFunctionCompiler(this, sourceInformationStrategy, useKernel);
serialization = new JavaScriptBackendSerialization(this);
+ backendClasses = new JavaScriptBackendClasses(helpers);
}
ConstantSystem get constantSystem => constants.constantSystem;
@@ -1121,7 +1128,7 @@ class JavaScriptBackend extends Backend {
registerBackendUse(helpers.createRuntimeType);
}
impactBuilder.registerTypeUse(
- new TypeUse.instantiation(typeImplementation.rawType));
+ new TypeUse.instantiation(backendClasses.typeImplementation.rawType));
}
lookupMapAnalysis.registerConstantKey(constant);
}
@@ -1139,7 +1146,7 @@ class JavaScriptBackend extends Backend {
helpers.setRuntimeTypeInfo,
null));
}
- if (type.element == typeImplementation) {
+ if (type.element == backendClasses.typeImplementation) {
// If we use a type literal in a constant, the compile time
// constant emitter will generate a call to the createRuntimeType
// helper so we register a use of that.
@@ -1897,30 +1904,6 @@ class JavaScriptBackend extends Backend {
return compiler.closedWorld.hasOnlySubclasses(classElement);
}
- bool isNullImplementation(ClassElement cls) {
- return cls == helpers.jsNullClass;
- }
-
- ClassElement get intImplementation => helpers.jsIntClass;
- ClassElement get uint32Implementation => helpers.jsUInt32Class;
- ClassElement get uint31Implementation => helpers.jsUInt31Class;
- ClassElement get positiveIntImplementation => helpers.jsPositiveIntClass;
- ClassElement get doubleImplementation => helpers.jsDoubleClass;
- ClassElement get numImplementation => helpers.jsNumberClass;
- ClassElement get stringImplementation => helpers.jsStringClass;
- ClassElement get listImplementation => helpers.jsArrayClass;
- ClassElement get constListImplementation => helpers.jsUnmodifiableArrayClass;
- ClassElement get fixedListImplementation => helpers.jsFixedArrayClass;
- ClassElement get growableListImplementation => helpers.jsExtendableArrayClass;
- ClassElement get mapImplementation => helpers.mapLiteralClass;
- ClassElement get constMapImplementation => helpers.constMapLiteralClass;
- ClassElement get typeImplementation => helpers.typeLiteralClass;
- ClassElement get boolImplementation => helpers.jsBoolClass;
- ClassElement get nullImplementation => helpers.jsNullClass;
- ClassElement get syncStarIterableImplementation => helpers.syncStarIterable;
- ClassElement get asyncFutureImplementation => helpers.futureImplementation;
- ClassElement get asyncStarStreamImplementation => helpers.controllerStream;
-
void registerStaticUse(Element element, Enqueuer enqueuer) {
if (element == helpers.disableTreeShakingMarker) {
isTreeShakingDisabled = true;
@@ -3257,3 +3240,30 @@ class JavaScriptImpactStrategy extends ImpactStrategy {
}
}
}
+
+class JavaScriptBackendClasses implements BackendClasses {
+ final BackendHelpers helpers;
+
+ JavaScriptBackendClasses(this.helpers);
+
+ ClassElement get intImplementation => helpers.jsIntClass;
+ ClassElement get uint32Implementation => helpers.jsUInt32Class;
+ ClassElement get uint31Implementation => helpers.jsUInt31Class;
+ ClassElement get positiveIntImplementation => helpers.jsPositiveIntClass;
+ ClassElement get doubleImplementation => helpers.jsDoubleClass;
+ ClassElement get numImplementation => helpers.jsNumberClass;
+ ClassElement get stringImplementation => helpers.jsStringClass;
+ ClassElement get listImplementation => helpers.jsArrayClass;
+ ClassElement get constListImplementation => helpers.jsUnmodifiableArrayClass;
+ ClassElement get fixedListImplementation => helpers.jsFixedArrayClass;
+ ClassElement get growableListImplementation => helpers.jsExtendableArrayClass;
+ ClassElement get mapImplementation => helpers.mapLiteralClass;
+ ClassElement get constMapImplementation => helpers.constMapLiteralClass;
+ ClassElement get typeImplementation => helpers.typeLiteralClass;
+ ClassElement get boolImplementation => helpers.jsBoolClass;
+ ClassElement get nullImplementation => helpers.jsNullClass;
+ ClassElement get syncStarIterableImplementation => helpers.syncStarIterable;
+ ClassElement get asyncFutureImplementation => helpers.futureImplementation;
+ ClassElement get asyncStarStreamImplementation => helpers.controllerStream;
+ ClassElement get functionImplementation => helpers.coreClasses.functionClass;
+}

Powered by Google App Engine
This is Rietveld 408576698