Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2370833002: Replace ClosedWorld.backend with ClosedWorld.backendClasses (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace ClosedWorld.backend with ClosedWorld.backendClasses R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/06d7fb2fc5ed9b2c09151cc0f9fc5dbfef8ff888

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -137 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 3 chunks +27 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 7 chunks +37 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 4 chunks +24 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/types/map_type_mask.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 4 chunks +26 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 7 chunks +11 lines, -14 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
https://codereview.chromium.org/2370833002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (left): https://codereview.chromium.org/2370833002/diff/1/pkg/compiler/lib/src/world.dart#oldcode696 pkg/compiler/lib/src/world.dart:696: // Used by selectors. No it isn't!
4 years, 2 months ago (2016-09-26 14:05:56 UTC) #3
Harry Terkelsen
lgtm
4 years, 2 months ago (2016-09-26 23:18:51 UTC) #4
Johnni Winther
4 years, 2 months ago (2016-09-27 08:34:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
06d7fb2fc5ed9b2c09151cc0f9fc5dbfef8ff888 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698