[CustomTabsBenchmark] Clear chrome local state between runs

[CustomTabsBenchmark] Clear chrome local state between runs

Committed: https://crrev.com/23bbefc79d091e3bc6deb5d123de6a95373a3bb8
Cr-Commit-Position: refs/heads/master@{#421480}

[droger, 2016-09-27 09:05:50]

Patchset #2 (id:20001) has been deleted

[droger, 2016-09-27 09:06:37]

droger@chromium.org changed reviewers:
+ lizeb@chromium.org

[Benoit L, 2016-09-27 14:29:05]

On 2016/09/27 09:06:37, droger wrote:

[Benoit L, 2016-09-27 14:54:45]

lgtm

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
File tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py (right):

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:30:
_CHROME_PACKAGE = 'com.google.android.apps.chrome'
Maybe add a comment to say that it corresponds to a local build of Chrome, not
Chromium.

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:35: for
directory in ['app_chrome/Default', 'cache', 'app_chrome/ShaderCache',
Where does this list come?

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:37: cmd =
['rm', '-rf', '/data/data/{}/{}'.format(_CHROME_PACKAGE, directory)]
rm can take several arguments, it woulb be a bit faster to issue a single
command to clear all the directories at once (by extending the command line
first with all the dirs, then calling adb).

[droger, 2016-09-27 15:39:13]

Thanks.

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
File tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py (right):

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:30:
_CHROME_PACKAGE = 'com.google.android.apps.chrome'
On 2016/09/27 14:54:45, Benoit L wrote:
> Maybe add a comment to say that it corresponds to a local build of Chrome, not
> Chromium.

Done.

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:35: for
directory in ['app_chrome/Default', 'cache', 'app_chrome/ShaderCache',
On 2016/09/27 14:54:45, Benoit L wrote:
> Where does this list come?

This comes from controller.py:
https://cs.chromium.org/chromium/src/tools/android/loading/controller.py?rcl=...

If you prefer, we could move this function to device_setup and share it instead.
I did not do it because I was thinking that controller.py may no longer works
since it has not been maintained, and was afraid to touch it.

https://codereview.chromium.org/2370823003/diff/40001/tools/android/customtab...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:37: cmd =
['rm', '-rf', '/data/data/{}/{}'.format(_CHROME_PACKAGE, directory)]
On 2016/09/27 14:54:45, Benoit L wrote:
> rm can take several arguments, it woulb be a bit faster to issue a single
> command to clear all the directories at once (by extending the command line
> first with all the dirs, then calling adb).

Done.

[droger, 2016-09-27 15:39:22]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 15:39:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:52:28]

Dry run: This issue passed the CQ dry run.

[droger, 2016-09-28 08:17:42]

The CQ bit was checked by droger@chromium.org

[droger, 2016-09-28 08:17:42]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/2370823003/#ps80001
(title: "list comprehension")

[commit-bot: I haz the power, 2016-09-28 08:17:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 08:25:51]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-28 08:28:09]

Description was changed from

==========
[CustomTabsBenchmark] Clear chrome local state between runs
==========

to

==========
[CustomTabsBenchmark] Clear chrome local state between runs

Committed: https://crrev.com/23bbefc79d091e3bc6deb5d123de6a95373a3bb8
Cr-Commit-Position: refs/heads/master@{#421480}
==========

[commit-bot: I haz the power, 2016-09-28 08:28:10]

Patchset 4 (id:??) landed as
https://crrev.com/23bbefc79d091e3bc6deb5d123de6a95373a3bb8
Cr-Commit-Position: refs/heads/master@{#421480}