Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2370813003: Move error codes and clean-up (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+718 lines, -736 lines) Patch
A pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 1 chunk +711 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 2 chunks +3 lines, -43 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 5 chunks +4 lines, -690 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Just a little more organization and clean up.
4 years, 2 months ago (2016-09-26 20:18:07 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-09-26 20:20:41 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-09-26 20:26:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9b882521e2e640e4a843cf731f25d2fe093f49af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698