Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 23708057: Emit compile-time errors for conflicting modifiers. (Closed)

Created:
7 years, 3 months ago by karlklose
Modified:
7 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Emit compile-time errors for conflicting modifiers. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27737

Patch Set 1 #

Patch Set 2 : Small fix to dart_backend_test. #

Patch Set 3 : Rebase. #

Patch Set 4 : Small fix to dart_backend_test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 3 months ago (2013-09-20 12:20:23 UTC) #1
Johnni Winther
lgtm
7 years, 3 months ago (2013-09-20 18:19:39 UTC) #2
karlklose
7 years, 3 months ago (2013-09-23 06:28:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r27737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698