Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 23708055: Skip tests failing on the no-i18n bot (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M test/intl/intl.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/run-deopt-fuzzer.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/run-tests.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-20 07:07:22 UTC) #1
Michael Achenbach
I'll land a patch that will skip most of the intl test262 tests through the ...
7 years, 3 months ago (2013-09-20 08:44:56 UTC) #2
Michael Achenbach
Patch landed: https://codereview.chromium.org/23792008/
7 years, 3 months ago (2013-09-20 09:32:47 UTC) #3
Michael Achenbach
The i18n config works. To make the system check work, see below: https://codereview.chromium.org/23708055/diff/8001/test/intl/intl.status File test/intl/intl.status ...
7 years, 3 months ago (2013-09-20 10:09:22 UTC) #4
jochen (gone - plz use gerrit)
done
7 years, 3 months ago (2013-09-20 10:24:43 UTC) #5
Michael Achenbach
lgtm
7 years, 3 months ago (2013-09-20 10:33:05 UTC) #6
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-20 10:49:45 UTC) #7
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-20 13:14:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r16867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698