dart/tools/bots/bot_utils.py - Issue 23708046: We can use subprocess.Popen(shell=True) only on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/bots/bot_utils.py

Issue 23708046: We can use subprocess.Popen(shell=True) only on windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/tools/bots/bot_utils.py

diff --git a/dart/tools/bots/bot_utils.py b/dart/tools/bots/bot_utils.py

index fb29a216ebe3e376fecc71e64deb4f08ab5c8c9c..c506014f611258430fc4fa8c2555afc081525856 100644

--- a/dart/tools/bots/bot_utils.py

+++ b/dart/tools/bots/bot_utils.py

@@ -186,7 +186,7 @@ class GSUtil(object):

gsutil_command = [sys.executable, GSUtil.GSUTIL_PATH]

run(gsutil_command + gsutil_args, env=env,

- shell=GSUtil.GSUTIL_IS_SHELL_SCRIPT)

+ shell=(GSUtil.GSUTIL_IS_SHELL_SCRIPT and sys.platform == 'win32'))

def upload(self, local_path, remote_path, recursive=False, public=False):

assert remote_path.startswith('gs://')

« no previous file with comments | « no previous file | no next file » | no next file with comments »