Reduce calling count of UpdateAppState()

chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 
 #include <vector>
 
 #include "ash/ash_switches.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 372 matching lines @@
                                app_id,
                                status,
                                index,
                                controller->GetLauncherItemType());
 }
 
 void ChromeLauncherController::SetItemStatus(
     ash::LauncherID id,
     ash::LauncherItemStatus status) {
   int index = model_->ItemIndexByID(id);
+  ash::LauncherItemStatus old_status = model_->items()[index].status;
   // Since ordinary browser windows are not registered, we might get a negative
   // index here.
-  if (index >= 0) {
+  if (index >= 0 && old_status != status) {
     ash::LauncherItem item = model_->items()[index];
     item.status = status;
     model_->Set(index, item);
   }
 }
 
 void ChromeLauncherController::SetItemController(
     ash::LauncherID id,
     LauncherItemController* controller) {
   CHECK(controller);
@@ skipping 421 matching lines @@
           ash::SHELF_AUTO_HIDE_BEHAVIOR_NEVER :
           ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS;
   SetShelfAutoHideBehaviorPrefs(behavior, root_window);
   return;
 }
 
 void ChromeLauncherController::RemoveTabFromRunningApp(
     WebContents* tab,
     const std::string& app_id) {
   web_contents_to_app_id_.erase(tab);
+  // For empty |app_id| tab, its state is udpated by UpdateBrowserItemState().

[Mr4D (OOO till 08-26), 2013/10/01 03:20:33]

What about:

UpdateBrowserItemState will update the state when no application is associated
with the tab.

[simonhong_, 2013/10/01 05:10:43]

Done.

+  if (app_id.empty())
+    return;
+
   AppIDToWebContentsListMap::iterator i_app_id =
       app_id_to_web_contents_list_.find(app_id);
   if (i_app_id != app_id_to_web_contents_list_.end()) {
     WebContentsList* tab_list = &i_app_id->second;
     tab_list->remove(tab);
     if (tab_list->empty()) {
       app_id_to_web_contents_list_.erase(i_app_id);
       i_app_id = app_id_to_web_contents_list_.end();
       ash::LauncherID id = GetLauncherIDForAppID(app_id);
       if (id)
@@ skipping 17 matching lines @@
     std::string last_app_id = web_contents_to_app_id_[contents];
     if (last_app_id != app_id)
       RemoveTabFromRunningApp(contents, last_app_id);
   }
 
   web_contents_to_app_id_[contents] = app_id;
 
   if (app_state == APP_STATE_REMOVED) {
     // The tab has gone away.
     RemoveTabFromRunningApp(contents, app_id);
-  } else {
+  } else if (!app_id.empty()) {
     WebContentsList& tab_list(app_id_to_web_contents_list_[app_id]);
 
     if (app_state == APP_STATE_INACTIVE) {
       WebContentsList::const_iterator i_tab =
           std::find(tab_list.begin(), tab_list.end(), contents);
       if (i_tab == tab_list.end())
         tab_list.push_back(contents);
+      // TODO(simon.hong81): Does this below case exist?
       if (i_tab != tab_list.begin()) {
         // Going inactive, but wasn't the front tab, indicating that a new
         // tab has already become active.
         return;
       }
     } else {
       tab_list.remove(contents);
       tab_list.push_front(contents);
     }
     ash::LauncherID id = GetLauncherIDForAppID(app_id);
@@ skipping 997 matching lines @@
 }
 
 void ChromeLauncherController::ReleaseProfile() {
   if (app_sync_ui_state_)
     app_sync_ui_state_->RemoveObserver(this);
 
   PrefServiceSyncable::FromProfile(profile_)->RemoveObserver(this);
 
   pref_change_registrar_.RemoveAll();
 }