Issue 23708026: Revert 222159 "Improve the UI for handling profile lock contention."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23708026: Revert 222159 "Improve the UI for handling profile lock contention." (Closed)

Created:
7 years, 3 months ago by please use gerrit instead

Modified:
7 years, 3 months ago

Reviewers:
palmer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 222159 "Improve the UI for handling profile lock contention." This change appears to have broken three unit tests: ProcessSingletonLinuxTest.NotifyOtherProcessDifferingHost ProcessSingletonLinuxTest.NotifyOtherProcessOrCreate_BadCookie ProcessSingletonLinuxTest.NotifyOtherProcessOrCreate_DifferingHost http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/38908 http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/49891 > Improve the UI for handling profile lock contention. > > Linux/GTK only. > > BUG=282509 > TEST=ln -s fake.com-123 SingletonLock, then run Chromium, then check that [ Quit ] and [ Unlock and Relaunch ] work. > > Review URL: https://chromiumcodereview.appspot.com/23506011 TBR=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222183

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -53 lines)			Patch
M	trunk/src/chrome/app/chromium_strings.grd	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/app/generated_resources.grd	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/app/google_chrome_strings.grd	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/process_singleton_linux.cc	View	3 chunks	+8 lines, -16 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/gtk/process_singleton_dialog.h	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/gtk/process_singleton_dialog.cc	View	3 chunks	+3 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

please use gerrit instead

7 years, 3 months ago (2013-09-10 02:10:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r222183.