Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 23708021: Do not clip inside OcclusionTracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added DCHECK Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 54e79baf8e28f3a7f630ed252155685b0ef72a78..2858a32e231afbe5355f18f654613ec8dd8a6f7c 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -570,7 +570,8 @@ static void AppendQuadsToFillScreen(
if (!root_layer || !SkColorGetA(screen_background_color))
return;
- Region fill_region = occlusion_tracker.ComputeVisibleRegionInScreen();
+ Region fill_region = occlusion_tracker.ComputeVisibleRegionInScreen(
+ root_layer->render_surface()->content_rect());
if (fill_region.IsEmpty())
return;
@@ -695,9 +696,7 @@ bool LayerTreeHostImpl::CalculateRenderPasses(FrameData* frame) {
settings_.show_overdraw_in_tracing &&
base::debug::TraceLog::GetInstance() &&
base::debug::TraceLog::GetInstance()->IsEnabled();
- OcclusionTrackerImpl occlusion_tracker(
- active_tree_->root_layer()->render_surface()->content_rect(),
- record_metrics_for_frame);
+ OcclusionTrackerImpl occlusion_tracker(record_metrics_for_frame);
occlusion_tracker.set_minimum_tracking_size(
settings_.minimum_occlusion_tracking_size);
@@ -772,8 +771,6 @@ bool LayerTreeHostImpl::CalculateRenderPasses(FrameData* frame) {
it->visible_content_rect(),
it->draw_transform(),
impl_draw_transform_is_unknown,
- it->is_clipped(),
- it->clip_rect(),
&has_occlusion_from_outside_target_surface)) {
append_quads_data.had_occlusion_from_outside_target_surface |=
has_occlusion_from_outside_target_surface;

Powered by Google App Engine
This is Rietveld 408576698