Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 23708015: Revert 157368 "Tables with display:inline rendered as block elem..." (Closed)

Created:
7 years, 3 months ago by inferno
Modified:
7 years, 3 months ago
Reviewers:
a.suchit
CC:
blink-reviews
Visibility:
Public.

Description

Revert 157368 "Tables with display:inline rendered as block elem..." Causing lots of use-after-frees on ClusterFuzz. > Tables with display:inline rendered as block element. > > Table was created as inline renderer and another table block renderer wrapper is > created for table's content. So it was displayed as block element and all its style > properties also associated with inline renderer and was not applied to table. > > Creating table inline-table renderer wrapper for table's content if parent > is inline except inline-block parent. > > R=eseidel@chromium.org > BUG=53693 > > Review URL: https://chromiumcodereview.appspot.com/23628004 TBR=a.suchit@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -90 lines) Patch
D trunk/LayoutTests/fast/table/table-display-inline.html View 1 chunk +0 lines, -63 lines 0 comments Download
MM trunk/LayoutTests/tables/mozilla/bugs/bug3037-1-expected.txt View 1 chunk +29 lines, -21 lines 0 comments Download
M trunk/Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/rendering/RenderTable.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
inferno
7 years, 3 months ago (2013-09-07 03:39:08 UTC) #1
inferno
7 years, 3 months ago (2013-09-07 03:39:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r157407.

Powered by Google App Engine
This is Rietveld 408576698