Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2370793004: Remove obsolete --running-performance-benchmark flag. (Closed)

Created:
4 years, 2 months ago by wkorman
Modified:
4 years, 2 months ago
Reviewers:
Ted C, nednguyen
CC:
chromium-reviews, jam, darin-cc_chromium.org, telemetry-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete --running-performance-benchmark flag. Flag was added in http://crrev.com/433623002/ but does not appear to be in use any longer (and appears to have only been used for Clank-specific purposes). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/b976c3737d40f222d9efb0c92de17c0fa0f9c2df Cr-Commit-Position: refs/heads/master@{#421207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/measurements/smoothness.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
wkorman
I can't find any refs in code base other than these. Running CQ dry run ...
4 years, 2 months ago (2016-09-26 22:32:47 UTC) #4
nednguyen
lgtm
4 years, 2 months ago (2016-09-26 22:54:26 UTC) #7
Ted C
lgtm
4 years, 2 months ago (2016-09-26 23:20:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370793004/1
4 years, 2 months ago (2016-09-27 05:48:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_cq/builds/536)
4 years, 2 months ago (2016-09-27 13:23:56 UTC) #14
nednguyen
On 2016/09/27 13:23:56, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-09-27 14:39:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370793004/1
4 years, 2 months ago (2016-09-27 14:39:41 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 14:45:23 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 14:47:19 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b976c3737d40f222d9efb0c92de17c0fa0f9c2df
Cr-Commit-Position: refs/heads/master@{#421207}

Powered by Google App Engine
This is Rietveld 408576698