Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issue 2370793003: Blink: Convert scaled-sprited-background.html to be a pixel test. (Closed)

Created:
4 years, 2 months ago by vmpstr
Modified:
4 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink: Convert scaled-sprited-background.html to be a pixel test. This patch converts the referenced test from a ref test to a pixel test. R=chrishtr@chromium.org BUG=649046 Committed: https://crrev.com/e3a682363b85c528fed136517a1b39050a7d487f Cr-Commit-Position: refs/heads/master@{#421010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/backgrounds/size/scaled-sprited-background-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look. I'm not sure if I'm supposed to add a dummy png ...
4 years, 2 months ago (2016-09-26 19:07:08 UTC) #1
chrishtr
lgtm
4 years, 2 months ago (2016-09-26 20:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370793003/1
4 years, 2 months ago (2016-09-26 20:59:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 21:57:25 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 22:00:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3a682363b85c528fed136517a1b39050a7d487f
Cr-Commit-Position: refs/heads/master@{#421010}

Powered by Google App Engine
This is Rietveld 408576698