Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2370783003: Avoid SVG viewport bug for CSS length animations that don't use viewport units (Closed)

Created:
4 years, 2 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid SVG viewport bug for CSS length animations that don't use viewport units This change optimises LengthInterpolationFunctions::createLength() to skip processing units whose corresponding values are zero. This avoids the nanification of Length for the majority of CSS length animations that don't use viewport units in SVG images. See crbug.com/650147 for further details on nan viewport units in SVG images. BUG=650147, 650216 Committed: https://crrev.com/1ad339d4e001d04db7f63a1d0daa3cb17b5bac64 Cr-Commit-Position: refs/heads/master@{#421137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/svg/animations/img-tag-css-length-animation-crash.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alancutter (OOO until 2018)
4 years, 2 months ago (2016-09-27 04:44:42 UTC) #2
Timothy Loh
lgtm
4 years, 2 months ago (2016-09-27 04:46:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370783003/1
4 years, 2 months ago (2016-09-27 04:47:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 07:34:49 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 07:36:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ad339d4e001d04db7f63a1d0daa3cb17b5bac64
Cr-Commit-Position: refs/heads/master@{#421137}

Powered by Google App Engine
This is Rietveld 408576698