third_party/WebKit/Source/core/html/HTMLIFrameElement.idl - Issue 2370783002: Adding CSP attribute on HTMLIFrameElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.idl

Issue 2370783002: Adding CSP attribute on HTMLIFrameElement (Closed)

Patch Set: Adding formatting to the test file Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>	3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 27 matching lines...) Expand all Loading...
38	38

39 // obsolete members	39 // obsolete members

40 // https://html.spec.whatwg.org/#HTMLIFrameElement-partial	40 // https://html.spec.whatwg.org/#HTMLIFrameElement-partial

41 [CEReactions, Reflect] attribute DOMString align;	41 [CEReactions, Reflect] attribute DOMString align;

42 [CEReactions, Reflect] attribute DOMString scrolling;	42 [CEReactions, Reflect] attribute DOMString scrolling;

43 [CEReactions, Reflect] attribute DOMString frameBorder;	43 [CEReactions, Reflect] attribute DOMString frameBorder;

44 [CEReactions, Reflect, URL] attribute DOMString longDesc;	44 [CEReactions, Reflect, URL] attribute DOMString longDesc;

45	45

46 [CEReactions, Reflect, TreatNullAs=EmptyString] attribute DOMString marginHe ight;	46 [CEReactions, Reflect, TreatNullAs=EmptyString] attribute DOMString marginHe ight;

47 [CEReactions, Reflect, TreatNullAs=EmptyString] attribute DOMString marginWi dth;	47 [CEReactions, Reflect, TreatNullAs=EmptyString] attribute DOMString marginWi dth;

	48 [RuntimeEnabled=EmbedderCSPEnforcement, CEReactions, Reflect, TreatNullAs=Em ptyString] attribute DOMString csp;
	Mike West 2016/09/26 14:55:02 1. Please move this up out of the `// obsolete mem 1. Please move this up out of the `// obsolete members` section, and add a comment pointing to the spec (`https://w3c.github.io/webappsec-csp/embedded/#dom-htmliframeelement-csp`). 2. Please drop the `TreatNullAs` bit. I don't think we need it here. It means that `i.csp = null` would be treated as `i.csp = ""`, which doesn't seem like a restriction we need to add. :)
48 };	49 };

OLD	NEW