third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/iframe-csp-attribute.html - Issue 2370783002: Adding CSP attribute on HTMLIFrameElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/iframe-csp-attribute.html

Issue 2370783002: Adding CSP attribute on HTMLIFrameElement (Closed)

Patch Set: Adding formatting to the test file Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="/resources/testharness.js"></script>

	5 <script src="/resources/testharnessreport.js"></script>

	6 </head>

	7 <body>

	8 <script>

	9 test(t => {

	10 var i = document.createElement('iframe');

	11 assert_equals('', i.csp);

	12 assert_equals('string', typeof (i.csp));
	Mike West 2016/09/26 14:55:02 Nit: Can you add `assert_true('csp' in i)`? Nit: Can you add `assert_true('csp' in i)`?
	13 }, "<iframe> has a 'csp' attibute which is an empty string if undefined.") ;

	14

	15 test(t => {

	16 var i = document.createElement('iframe');

	17 i.setAttribute('csp', 123456);

	18 assert_equals('123456', i.csp);

	19 }, "<iframe>'s csp attribute is always a string.");

	20

	21 test(t => {

	22 var i = document.createElement('iframe');

	23 i.csp = 'value';

	24 assert_equals('value', i.getAttribute('csp'));

	25 }, "<iframe> has a 'csp' attibute.");
	Mike West 2016/09/26 14:55:02 Nit: Perhaps "<iframe>'s 'csp' content attribute r Nit: Perhaps "<iframe>'s 'csp' content attribute reflects the IDL attribute."
	26

	27 test(t => {

	28 var first_iframe = document.createElement('iframe');

	29 var second_iframe = document.createElement('iframe');

	30

	31 first_iframe.setAttribute('csp', 'value 1');

	32 assert_equals('value 1', first_iframe.csp);

	33

	34 second_iframe.setAttribute('csp', 'value 2');

	35 assert_equals('value 2', second_iframe.csp);

	36 }, "'csp' attribute of <iframe> has proper value.");
	Mike West 2016/09/26 14:55:02 Nit: Perhaps "<iframe>'s IDL attribute reflects th Nit: Perhaps "<iframe>'s IDL attribute reflects the DOM attribute." Why did you add a second frame? It's not clear what it's testing that isn't tested with the first frame.
	37 </script>

	38 </body>

	39 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLAttributeNames.in » ('j') | third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp » ('J')