Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2370763002: Revert "[turbofan] Remove the representation dimension from Type." (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[turbofan] Remove the representation dimension from Type." Reverted for stability reasons. BUG=chromium:649967 TBR=jarin@chromium.org Committed: https://crrev.com/f584ca30880c7fae41d49f4e1ed4b72dc0ffb704 Cr-Commit-Position: refs/heads/master@{#39720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -78 lines) Patch
M src/compiler/representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/types.h View 11 chunks +100 lines, -34 lines 0 comments Download
M src/compiler/types.cc View 16 chunks +99 lines, -43 lines 0 comments Download
M test/cctest/test-types.cc View 2 chunks +68 lines, -0 lines 0 comments Download
M test/cctest/types-fuzz.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370763002/1
4 years, 2 months ago (2016-09-26 12:05:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 12:55:40 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 12:56:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f584ca30880c7fae41d49f4e1ed4b72dc0ffb704
Cr-Commit-Position: refs/heads/master@{#39720}

Powered by Google App Engine
This is Rietveld 408576698