[inspector] added inspector test runner [part 4]

[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Committed: https://crrev.com/d1191e1b8a12877b34668c52be1ab74cbb1d9c47
Cr-Original-Commit-Position: refs/heads/master@{#39895}
Cr-Commit-Position: refs/heads/master@{#39930}

[kozy, 2016-09-26 21:48:03]

Dmitry, please take a look.

[kozy, 2016-09-27 20:48:03]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 4]

- added inspector-protocol test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:645640
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector protocol test runner [part 4]

- added inspector-protocol test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:645640
R=dgozman@chromium.org,alph@chromium.org
==========

[kozy, 2016-09-27 20:48:03]

kozyatinskiy@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-09-28 10:27:01]

Python lgtm. Of course we won't see much until we migrate any tests.

Didn't review js file.

https://codereview.chromium.org/2370743003/diff/60001/test/inspector-protocol...
File test/inspector-protocol/testcfg.py (right):

https://codereview.chromium.org/2370743003/diff/60001/test/inspector-protocol...
test/inspector-protocol/testcfg.py:57: def IsFailureOutput(self, testcase):
Also have a look here:
https://cs.chromium.org/chromium/src/v8/test/webkit/testcfg.py?q=test/webkit/...

V8 is chatty in some test variants and the extra lines must be ignored. Unless
we don't test those variants.

[kozy, 2016-09-28 21:21:49]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 4]

- added inspector-protocol test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:645640
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector protocol test runner [part 4]

- added inspector-protocol test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[kozy, 2016-09-28 22:17:10]

Patchset #7 (id:120001) has been deleted

[kozy, 2016-09-28 22:17:18]

Patchset #5 (id:80001) has been deleted

[kozy, 2016-09-28 22:17:25]

Patchset #5 (id:100001) has been deleted

[kozy, 2016-09-28 22:17:31]

Patchset #5 (id:140001) has been deleted

[kozy, 2016-09-28 22:21:55]

Patchset #5 (id:160001) has been deleted

[kozy, 2016-09-29 00:06:45]

Thanks!
I reused IsFailureOutput from test/webkit/testcfg.py.

https://codereview.chromium.org/2370743003/diff/60001/test/inspector-protocol...
File test/inspector-protocol/testcfg.py (right):

https://codereview.chromium.org/2370743003/diff/60001/test/inspector-protocol...
test/inspector-protocol/testcfg.py:57: def IsFailureOutput(self, testcase):
On 2016/09/28 10:27:01, machenbach (slow) wrote:
> Also have a look here:
>
https://cs.chromium.org/chromium/src/v8/test/webkit/testcfg.py?q=test/webkit/...
> 
> V8 is chatty in some test variants and the extra lines must be ignored. Unless
> we don't test those variants.

Reused from test/webkit.

[kozy, 2016-09-29 05:19:44]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 4]

- added inspector-protocol test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[kozy, 2016-09-29 22:36:13]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:36:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 22:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 22:54:10]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9959)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[kozy, 2016-09-30 00:00:50]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 00:01:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 00:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 00:26:17]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-30 00:44:52]

lgtm

https://codereview.chromium.org/2370743003/diff/220001/test/inspector/protoco...
File test/inspector/protocol-test.js (right):

https://codereview.chromium.org/2370743003/diff/220001/test/inspector/protoco...
test/inspector/protocol-test.js:142: InspectorTest.log("Error while executing '"
+ string + "': " + message.error.message);
Let's also completeTest.

[kozy, 2016-09-30 01:12:41]

All done. thanks!

https://codereview.chromium.org/2370743003/diff/220001/test/inspector/protoco...
File test/inspector/protocol-test.js (right):

https://codereview.chromium.org/2370743003/diff/220001/test/inspector/protoco...
test/inspector/protocol-test.js:142: InspectorTest.log("Error while executing '"
+ string + "': " + message.error.message);
On 2016/09/30 00:44:52, dgozman wrote:
> Let's also completeTest.

Done.

[kozy, 2016-09-30 01:12:57]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-30 01:12:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2370743003/#ps240001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-09-30 01:13:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 01:35:33]

Description was changed from

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[commit-bot: I haz the power, 2016-09-30 01:35:35]

Committed patchset #8 (id:240001)

[commit-bot: I haz the power, 2016-09-30 01:35:52]

Description was changed from

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Cr-Commit-Position: refs/heads/master@{#39895}
==========

[commit-bot: I haz the power, 2016-09-30 01:35:54]

Patchset 8 (id:??) landed as
https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Cr-Commit-Position: refs/heads/master@{#39895}

[kozy, 2016-09-30 18:04:08]

Description was changed from

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Cr-Commit-Position: refs/heads/master@{#39895}
==========

to

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Cr-Commit-Position: refs/heads/master@{#39895}
==========

[kozy, 2016-10-02 19:16:58]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-10-02 19:17:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 19:41:20]

Description was changed from

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Cr-Commit-Position: refs/heads/master@{#39895}
==========

to

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Cr-Commit-Position: refs/heads/master@{#39895}
==========

[commit-bot: I haz the power, 2016-10-02 19:41:21]

Committed patchset #8 (id:240001)

[commit-bot: I haz the power, 2016-10-02 19:41:37]

Description was changed from

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Cr-Commit-Position: refs/heads/master@{#39895}
==========

to

==========
[inspector] added inspector test runner [part 4]

- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Committed: https://crrev.com/d1191e1b8a12877b34668c52be1ab74cbb1d9c47
Cr-Original-Commit-Position: refs/heads/master@{#39895}
Cr-Commit-Position: refs/heads/master@{#39930}
==========

[commit-bot: I haz the power, 2016-10-02 19:41:38]

Patchset 8 (id:??) landed as
https://crrev.com/d1191e1b8a12877b34668c52be1ab74cbb1d9c47
Cr-Commit-Position: refs/heads/master@{#39930}