Issue 23707059: gyp: Add AIX support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23707059: gyp: Add AIX support

Created:
7 years, 3 months ago by David Edelsohn

Modified:
7 years, 3 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add AIX support Define LINK_COMMANDS_AIX Add aix_too.gyp to CopyTool AIX support to implement flock BUG=

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+30 lines, -6 lines)			Patch
pylib/gyp/aix_tool.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download
pylib/gyp/common.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
pylib/gyp/generator/make.py	View	2 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

David Edelsohn

Add AIX support to gyp/generator/make.py and aix_tool.py like sun_tool.py for flock support. https://codereview.chromium.org/23707059/ Thanks, David

7 years, 3 months ago (2013-09-23 16:48:49 UTC) #1

Nico

7 years, 3 months ago (2013-09-23 16:59:25 UTC) #2

Looks fine I suppose. A few questions:

* Since there's no test coverage for aix, this might break in the future. I
guess that's ok?
* This looks very similar to the sun pieces with s/sun/aix/ – can we just share
that code instead of copy it?
* What do you intend to use this for?
* It looks like you prefer make over ninja – why?

Expand Messages | Collapse Messages