Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2370703004: Re-enable an IndexedDB test that used to crash on Android. (Closed)

Created:
4 years, 2 months ago by pwnall
Modified:
4 years, 2 months ago
Reviewers:
cmumford
CC:
chromium-reviews, jam, jsbell+idb_chromium.org, darin-cc_chromium.org, cmumford
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable an IndexedDB test that used to crash on Android. This test was disabled in https://crrev.com/242483 to fix the crash documented in https://crbug.com/342525 BUG=342525 Committed: https://crrev.com/2c32acd5cba0d21b7304e384bcb232c6a973406e Cr-Commit-Position: refs/heads/master@{#422951}

Patch Set 1 #

Patch Set 2 : Added a tiny fix to a comment in the re-enabled test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/test/data/indexeddb/cursor_prefetch.js View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
pwnall
PTAL?
4 years, 2 months ago (2016-09-27 01:39:34 UTC) #7
cmumford
It looks like the content browser tests are still crashing on linux_android_rel_ng, but the logs ...
4 years, 2 months ago (2016-09-28 17:11:56 UTC) #8
pwnall
On 2016/09/28 17:11:56, cmumford wrote: > It looks like the content browser tests are still ...
4 years, 2 months ago (2016-09-29 21:13:12 UTC) #9
pwnall
I squeezed in a tiny non-functional fix for the test that's getting re-enabled on Android. ...
4 years, 2 months ago (2016-09-29 21:41:54 UTC) #10
cmumford
lgtm - lets keep an eye on the test for a few days to see.
4 years, 2 months ago (2016-10-04 19:49:33 UTC) #15
pwnall
On 2016/10/04 19:49:33, cmumford wrote: > lgtm - lets keep an eye on the test ...
4 years, 2 months ago (2016-10-04 20:33:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370703004/30001
4 years, 2 months ago (2016-10-04 20:34:03 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:30001)
4 years, 2 months ago (2016-10-04 22:05:43 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:08:55 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c32acd5cba0d21b7304e384bcb232c6a973406e
Cr-Commit-Position: refs/heads/master@{#422951}

Powered by Google App Engine
This is Rietveld 408576698