Issue 23707028: Revert 222226 "App windows with ids should remember fullscreen s..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23707028: Revert 222226 "App windows with ids should remember fullscreen s..." (Closed)

Created:
7 years, 3 months ago by Jói

Modified:
7 years, 3 months ago

Reviewers:
zhchbin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 222226 "App windows with ids should remember fullscreen s..." > App windows with ids should remember fullscreen state. > > BUG=242790 > TEST=PlatformAppBrowserTest.ShellWindowRestoreState > TEST=1. Install window-state-sample: https://chrome.google.com/webstore/detail/window-state-sample/hcbhfbnaaancmblfhdknlnojpafjohbi; 2. Run the app and create a new window with id. 3. Fullscreen the new window by clicking "Fullscreen" of "chrome.app.window" section; 4. Close the window (You can use "Alt+F4" etc.) and recreate the new window with the same id. 5. A fullscreen window should be shown. > > Review URL: https://chromiumcodereview.appspot.com/23672029 Reason for revert: Causes PlatformAppBrowserTest.ShellWindowRestoreState to fail on Mac OS X 10.6. TBR=zhchbin@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222247

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -15 lines)			Patch
M	trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/gtk/apps/native_app_window_gtk.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	trunk/src/chrome/test/data/extensions/platform_apps/restore_state/test.js	View	2 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r222247.