Issue 23707025: Revert 221776 "RenderTextWin: Break runs between any two charact..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23707025: Revert 221776 "RenderTextWin: Break runs between any two charact..." (Closed)

Created:
7 years, 3 months ago by please use gerrit instead

Modified:
7 years, 3 months ago

Reviewers:
ckocagil

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 221776 "RenderTextWin: Break runs between any two charact..." Compile error: render_text_unittest.cc(1662) :error C2039: 'Range' : is not a member of 'ui' Revision 221776 change collided with revision 221762, which moved Range from ui to gfx namespace. > RenderTextWin: Break runs between any two characters that are not in the same code block > > BUG=278913 > > Review URL: https://chromiumcodereview.appspot.com/23522018 TBR=ckocagil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221780

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -56 lines)			Patch
M	trunk/src/ui/gfx/render_text_unittest.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	trunk/src/ui/gfx/render_text_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/ui/gfx/render_text_win.cc	View	5 chunks	+7 lines, -33 lines	0 comments	Download

Total messages: 4 (0 generated)

please use gerrit instead

Committed patchset #1 manually as r221780.

7 years, 3 months ago (2013-09-06 21:12:55 UTC) #2

Alexei Svitkine (slow)

Looks like this had a mid-air collision with http://crrev.com/221762

7 years, 3 months ago (2013-09-06 21:25:59 UTC) #3

Message was sent while issue was closed.

Correct.