Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 23707010: Implement Display id field in ScreenWin. (Closed)

Created:
7 years, 3 months ago by Haojian Wu
Modified:
7 years, 3 months ago
Reviewers:
oshima, Haojian Wu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement Display id field in ScreenWin. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221237

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M ui/gfx/screen_win.cc View 1 4 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Haojian Wu
Please review it. Thanks.
7 years, 3 months ago (2013-08-30 13:52:32 UTC) #1
oshima
https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc File ui/gfx/screen_win.cc (left): https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc#oldcode17 ui/gfx/screen_win.cc:17: MONITORINFO monitor_info = { 0 }; Any reason to ...
7 years, 3 months ago (2013-08-30 18:15:13 UTC) #2
Haojian Wu
https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc File ui/gfx/screen_win.cc (left): https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc#oldcode17 ui/gfx/screen_win.cc:17: MONITORINFO monitor_info = { 0 }; On 2013/08/30 18:15:13, ...
7 years, 3 months ago (2013-08-31 14:17:07 UTC) #3
oshima
https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc File ui/gfx/screen_win.cc (left): https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc#oldcode17 ui/gfx/screen_win.cc:17: MONITORINFO monitor_info = { 0 }; On 2013/08/31 14:17:07, ...
7 years, 3 months ago (2013-09-03 18:04:44 UTC) #4
Haojian Wu
On 2013/09/03 18:04:44, oshima wrote: > https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc > File ui/gfx/screen_win.cc (left): > > https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc#oldcode17 > ...
7 years, 3 months ago (2013-09-04 00:18:50 UTC) #5
oshima
On 2013/09/04 00:18:50, Haojian Wu wrote: > On 2013/09/03 18:04:44, oshima wrote: > > https://codereview.chromium.org/23707010/diff/1/ui/gfx/screen_win.cc ...
7 years, 3 months ago (2013-09-04 01:18:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/23707010/4001
7 years, 3 months ago (2013-09-04 04:21:31 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 19:14:17 UTC) #8
Message was sent while issue was closed.
Change committed as 221237

Powered by Google App Engine
This is Rietveld 408576698