test/cctest/test-weakmaps.cc - Issue 23707009: Deprecate Persistent functions which were marked to be deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-weakmaps.cc

Issue 23707009: Deprecate Persistent functions which were marked to be deprecated. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Code review (svenpanne) Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-weakmaps.cc

diff --git a/test/cctest/test-weakmaps.cc b/test/cctest/test-weakmaps.cc

index 9044f17e4e39f7b56aeef11462457220090c52f7..932b06b85018537199958f6be787c49b55e11711 100644

--- a/test/cctest/test-weakmaps.cc

+++ b/test/cctest/test-weakmaps.cc

@@ -69,7 +69,7 @@ static void WeakPointerCallback(v8::Isolate* isolate,

void* id) {

ASSERT(id == reinterpret_cast<void*>(1234));

NumberOfWeakCalls++;

- handle->Dispose(isolate);

+ handle->Dispose();

}

« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/cctest/test-weaksets.cc » ('j') | no next file with comments »