Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: test/cctest/test-declarative-accessors.cc

Issue 23707009: Deprecate Persistent functions which were marked to be deprecated. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code review (svenpanne) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-decls.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 20 matching lines...) Expand all
31 31
32 #include "cctest.h" 32 #include "cctest.h"
33 33
34 using namespace v8::internal; 34 using namespace v8::internal;
35 35
36 36
37 class HandleArray : public Malloced { 37 class HandleArray : public Malloced {
38 public: 38 public:
39 static const unsigned kArraySize = 200; 39 static const unsigned kArraySize = 200;
40 explicit HandleArray() {} 40 explicit HandleArray() {}
41 ~HandleArray() { Reset(v8::Isolate::GetCurrent()); } 41 ~HandleArray() { Reset(); }
42 void Reset(v8::Isolate* isolate) { 42 void Reset() {
43 for (unsigned i = 0; i < kArraySize; i++) { 43 for (unsigned i = 0; i < kArraySize; i++) {
44 if (handles_[i].IsEmpty()) continue; 44 if (handles_[i].IsEmpty()) continue;
45 handles_[i].Dispose(isolate); 45 handles_[i].Dispose();
46 handles_[i].Clear(); 46 handles_[i].Clear();
47 } 47 }
48 } 48 }
49 v8::Persistent<v8::Value> handles_[kArraySize]; 49 v8::Persistent<v8::Value> handles_[kArraySize];
50 private: 50 private:
51 DISALLOW_COPY_AND_ASSIGN(HandleArray); 51 DISALLOW_COPY_AND_ASSIGN(HandleArray);
52 }; 52 };
53 53
54 54
55 // An aligned character array of size 1024. 55 // An aligned character array of size 1024.
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 int internal_field = 0; 291 int internal_field = 0;
292 v8::Handle<v8::DeclaredAccessorDescriptor> descriptor = 292 v8::Handle<v8::DeclaredAccessorDescriptor> descriptor =
293 OOD::NewInternalFieldDereference(helper.isolate_, internal_field) 293 OOD::NewInternalFieldDereference(helper.isolate_, internal_field)
294 ->NewRawShift(helper.isolate_, index*kPointerSize) 294 ->NewRawShift(helper.isolate_, index*kPointerSize)
295 ->NewHandleDereference(helper.isolate_); 295 ->NewHandleDereference(helper.isolate_);
296 HandleArray* array = *helper.handle_array_; 296 HandleArray* array = *helper.handle_array_;
297 v8::Handle<v8::String> expected = v8_str("whatever"); 297 v8::Handle<v8::String> expected = v8_str("whatever");
298 array->handles_[index].Reset(helper.isolate_, expected); 298 array->handles_[index].Reset(helper.isolate_, expected);
299 VerifyRead(descriptor, internal_field, array, expected); 299 VerifyRead(descriptor, internal_field, array, expected);
300 } 300 }
OLDNEW
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-decls.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698