Issue 23707008: Make arguments to CSSMediaRule.insertRule() / deleteRule() mandatory

Issue 23707008: Make arguments to CSSMediaRule.insertRule() / deleteRule() mandatory (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, arv (Not doing code reviews), kenneth.r.christiansen, rune

CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, darktears, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make arguments to CSSMediaRule.insertRule() / deleteRule() mandatory Make arguments to CSSMediaRule.insertRule() / deleteRule() mandatory as per the specification: http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSMediaRule This behavior is consistent with Firefox 23 and IE10. It is confusing what is supposed to happen if the arguments are omitted. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157066

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -7 lines)			Patch
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSMediaRule.idl	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 8 (0 generated)

do-not-use

Validated on Firefox and IE using: http://jsfiddle.net/r4e5x/5/

7 years, 3 months ago (2013-08-30 11:02:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23707008/1

7 years, 3 months ago (2013-09-02 05:41:59 UTC) #7

Message was sent while issue was closed.

Change committed as 157066