src/full-codegen/x64/full-codegen-x64.cc - Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof. (Closed)

Patch Set: Fix registers on arm/arm64. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 1be891a95db47dc1efa33ce5f7ec3d72cf9b5505..64f52edd61a93c8f674d8fdcdf756b15e0c5cf74 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -3325,7 +3325,9 @@ void FullCodeGenerator::VisitCompareOperation(CompareOperation* expr) {

VisitForAccumulatorValue(expr->right());

SetExpressionPosition(expr);

PopOperand(rdx);

- InstanceOfStub stub(isolate());

+ __ EmitLoadTypeFeedbackVector(rbx);

+ __ Set(rdi, SlotToIndex(expr->CompareOperationFeedbackSlot()));

+ InstanceOfWithFeedbackStub stub(isolate());

__ CallStub(&stub);

PrepareForBailoutBeforeSplit(expr, false, NULL, NULL);

__ CompareRoot(rax, Heap::kTrueValueRootIndex);