src/full-codegen/mips/full-codegen-mips.cc - Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof. (Closed)

Patch Set: Fix registers on arm/arm64. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/mips/full-codegen-mips.cc

diff --git a/src/full-codegen/mips/full-codegen-mips.cc b/src/full-codegen/mips/full-codegen-mips.cc

index 46aea7bd1a55c961a043a1a575b9d0a37a6c4dd8..3c42d4ea135e4afc3608ffbb6d2bab9cd6a9bda9 100644

--- a/src/full-codegen/mips/full-codegen-mips.cc

+++ b/src/full-codegen/mips/full-codegen-mips.cc

@@ -3446,7 +3446,9 @@ void FullCodeGenerator::VisitCompareOperation(CompareOperation* expr) {

SetExpressionPosition(expr);

__ mov(a0, result_register());

PopOperand(a1);

- InstanceOfStub stub(isolate());

+ __ EmitLoadTypeFeedbackVector(a3);

+ __ li(t0, Operand(SlotToIndex(expr->CompareOperationFeedbackSlot())));

+ InstanceOfWithFeedbackStub stub(isolate());

__ CallStub(&stub);

PrepareForBailoutBeforeSplit(expr, false, NULL, NULL);

__ LoadRoot(at, Heap::kTrueValueRootIndex);