src/full-codegen/arm/full-codegen-arm.cc - Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof. (Closed)

Patch Set: Fix registers on arm/arm64. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/arm/full-codegen-arm.cc

diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc

index ae1fa5b46cce7bea6ba2dcf6f5f89eeca0829002..554dd9ff4c83c16b6478d12c7bfa49d1ae25e3cf 100644

--- a/src/full-codegen/arm/full-codegen-arm.cc

+++ b/src/full-codegen/arm/full-codegen-arm.cc

@@ -3438,7 +3438,9 @@ void FullCodeGenerator::VisitCompareOperation(CompareOperation* expr) {

VisitForAccumulatorValue(expr->right());

SetExpressionPosition(expr);

PopOperand(r1);

- InstanceOfStub stub(isolate());

+ __ EmitLoadTypeFeedbackVector(r3);

+ __ mov(r4, Operand(SlotToIndex(expr->CompareOperationFeedbackSlot())));

+ InstanceOfWithFeedbackStub stub(isolate());

__ CallStub(&stub);

PrepareForBailoutBeforeSplit(expr, false, NULL, NULL);

__ CompareRoot(r0, Heap::kTrueValueRootIndex);

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »