Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof. (Closed)
Patch Set: Fix registers on arm/arm64. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 68cf58905f87e1f62e0d2186409657ba29861d39..926442e40eb79522bfd3bbda673151a1c23c37ca 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -2826,9 +2826,12 @@ void AstGraphBuilder::VisitCompareOperation(CompareOperation* expr) {
case Token::GTE:
op = javascript()->GreaterThanOrEqual(hint);
break;
- case Token::INSTANCEOF:
- op = javascript()->InstanceOf();
+ case Token::INSTANCEOF: {
+ VectorSlotPair feedback =
+ CreateVectorSlotPair(expr->CompareOperationFeedbackSlot());
+ op = javascript()->InstanceOf(feedback);
break;
+ }
case Token::IN:
op = javascript()->HasProperty();
break;
« no previous file with comments | « src/code-stubs.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698