Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: src/compiler/ast-graph-builder.cc

Issue 2370693002: [compiler] Properly guard the speculative optimizations for instanceof. (Closed)
Patch Set: Fix registers on arm/arm64. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-graph-builder.h" 5 #include "src/compiler/ast-graph-builder.h"
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/compilation-info.h" 9 #include "src/compilation-info.h"
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 2808 matching lines...) Expand 10 before | Expand all | Expand 10 after
2819 break; 2819 break;
2820 case Token::GT: 2820 case Token::GT:
2821 op = javascript()->GreaterThan(hint); 2821 op = javascript()->GreaterThan(hint);
2822 break; 2822 break;
2823 case Token::LTE: 2823 case Token::LTE:
2824 op = javascript()->LessThanOrEqual(hint); 2824 op = javascript()->LessThanOrEqual(hint);
2825 break; 2825 break;
2826 case Token::GTE: 2826 case Token::GTE:
2827 op = javascript()->GreaterThanOrEqual(hint); 2827 op = javascript()->GreaterThanOrEqual(hint);
2828 break; 2828 break;
2829 case Token::INSTANCEOF: 2829 case Token::INSTANCEOF: {
2830 op = javascript()->InstanceOf(); 2830 VectorSlotPair feedback =
2831 CreateVectorSlotPair(expr->CompareOperationFeedbackSlot());
2832 op = javascript()->InstanceOf(feedback);
2831 break; 2833 break;
2834 }
2832 case Token::IN: 2835 case Token::IN:
2833 op = javascript()->HasProperty(); 2836 op = javascript()->HasProperty();
2834 break; 2837 break;
2835 default: 2838 default:
2836 op = nullptr; 2839 op = nullptr;
2837 UNREACHABLE(); 2840 UNREACHABLE();
2838 } 2841 }
2839 VisitForValue(expr->left()); 2842 VisitForValue(expr->left());
2840 VisitForValue(expr->right()); 2843 VisitForValue(expr->right());
2841 Node* right = environment()->Pop(); 2844 Node* right = environment()->Pop();
(...skipping 1482 matching lines...) Expand 10 before | Expand all | Expand 10 after
4324 // Phi does not exist yet, introduce one. 4327 // Phi does not exist yet, introduce one.
4325 value = NewPhi(inputs, value, control); 4328 value = NewPhi(inputs, value, control);
4326 value->ReplaceInput(inputs - 1, other); 4329 value->ReplaceInput(inputs - 1, other);
4327 } 4330 }
4328 return value; 4331 return value;
4329 } 4332 }
4330 4333
4331 } // namespace compiler 4334 } // namespace compiler
4332 } // namespace internal 4335 } // namespace internal
4333 } // namespace v8 4336 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698