Don't add fake flash when command-line flash exists.

chrome/common/chrome_content_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_content_client.h"
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
@@ skipping 261 matching lines @@
                                            content::kFlashPluginSwfDescription);
   plugin.mime_types.push_back(swf_mime_type);
   content::WebPluginMimeType spl_mime_type(content::kFlashPluginSplMimeType,
                                            content::kFlashPluginSplExtension,
                                            content::kFlashPluginSplDescription);
   plugin.mime_types.push_back(spl_mime_type);
 
   return plugin;
 }
 
-void AddPepperFlashFromCommandLine(
-    std::vector<content::PepperPluginInfo>* plugins) {
+bool GetCommandLinePepperFlash(content::PepperPluginInfo* plugin) {
   const base::CommandLine::StringType flash_path =
       base::CommandLine::ForCurrentProcess()->GetSwitchValueNative(
           switches::kPpapiFlashPath);
   if (flash_path.empty())
-    return;
+    return false;
 
   // Also get the version from the command-line. Should be something like 11.2
   // or 11.2.123.45.
   std::string flash_version =
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
           switches::kPpapiFlashVersion);
 
-  plugins->push_back(
-      CreatePepperFlashInfo(base::FilePath(flash_path),
-                            flash_version, false, true, false));
+  *plugin = CreatePepperFlashInfo(base::FilePath(flash_path),
+                                  flash_version, false, true, false);
+  return true;
 }
 
 #if defined(OS_LINUX)
 // This function tests if DIR_USER_DATA can be accessed, as a simple check to
 // see if the zygote has been sandboxed at this point.
 bool IsUserDataDirAvailable() {
   base::FilePath user_data_dir;
   return PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
 }
 
@@ skipping 170 matching lines @@
   }
 
   return plugin_map.rbegin()->second;
 }
 #endif  // defined(ENABLE_PLUGINS)
 
 void ChromeContentClient::AddPepperPlugins(
     std::vector<content::PepperPluginInfo>* plugins) {
 #if defined(ENABLE_PLUGINS)
   ComputeBuiltInPlugins(plugins);
-  AddPepperFlashFromCommandLine(plugins);
 
+  ScopedVector<content::PepperPluginInfo> flash_versions;
+
+  std::unique_ptr<content::PepperPluginInfo> command_line_flash(
+      new content::PepperPluginInfo);
+  bool has_cli_flash = GetCommandLinePepperFlash(command_line_flash.get());
 #if defined(OS_LINUX)
-  // Depending on the sandbox configurtion, the user data directory
+  // Depending on the sandbox configuration, the user data directory
   // is not always available. If it is not available, do not try and load any
   // flash plugin. The flash player, if any, preloaded before the sandbox
   // initialization will continue to be used.
   if (!IsUserDataDirAvailable()) {
+    if (has_cli_flash)

[Greg K, 2016/09/26 22:54:14]

I'm confused by this: why do we want to push back the command line version here?
That check, which I coincidentally rewrote today into a more accurate check,
tests for file system access. In this if clause, there is no filesystem access
and Chrome won't be able to load any files at this point.

[waffles, 2016/09/26 23:02:32]

I don't know what the purpose of this is, I just decided it was wisest to retain
the existing behavior (command-line flash is added in
AddPepperFlashFromCommandLine before this `return`).

+      plugins->push_back(*command_line_flash);
     return;
   }
 #endif  // defined(OS_LINUX)
-
-  ScopedVector<content::PepperPluginInfo> flash_versions;
+  if (has_cli_flash)
+    flash_versions.push_back(command_line_flash.release());
 
 #if defined(OS_LINUX)
   std::unique_ptr<content::PepperPluginInfo> component_flash(
       new content::PepperPluginInfo);
   if (GetComponentUpdatedPepperFlash(component_flash.get()))
     flash_versions.push_back(component_flash.release());
 #endif  // defined(OS_LINUX)
 
   std::unique_ptr<content::PepperPluginInfo> system_flash(
       new content::PepperPluginInfo);
@@ skipping 175 matching lines @@
   if (!origin_trial_policy_)
     origin_trial_policy_ = base::MakeUnique<ChromeOriginTrialPolicy>();
   return origin_trial_policy_.get();
 }
 
 #if defined(OS_ANDROID)
 media::MediaClientAndroid* ChromeContentClient::GetMediaClientAndroid() {
   return new ChromeMediaClientAndroid();
 }
 #endif  // OS_ANDROID