Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2370683002: Convert editing/pasteboard/paste-table-002.html to use w3c test harness (Closed)

Created:
4 years, 2 months ago by yosin_UTC9
Modified:
4 years, 2 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/pasteboard/paste-table-002.html to use w3c test harness his patch converts "editing/pasteboard/paste-table-002.html" to use w3c test harness to simplify test case for improving code helath. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/24e648cb3305aa9ba91424dede65953815b76e07 Cr-Commit-Position: refs/heads/master@{#421149}

Patch Set 1 : 2016-09-26T15:49:39 #

Total comments: 2

Patch Set 2 : 2016-09-26T19:04:09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -74 lines) Patch
M third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html View 1 1 chunk +37 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
yosin_UTC9
PTAL
4 years, 2 months ago (2016-09-26 08:49:15 UTC) #6
Xiaocheng
https://codereview.chromium.org/2370683002/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html File third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html (right): https://codereview.chromium.org/2370683002/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html#newcode18 third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html:18: '</div>', This <div> also contains |ghijk| in the original ...
4 years, 2 months ago (2016-09-26 09:13:36 UTC) #7
yosin_UTC9
PTAL https://codereview.chromium.org/2370683002/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html File third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html (right): https://codereview.chromium.org/2370683002/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html#newcode18 third_party/WebKit/LayoutTests/editing/pasteboard/paste-table-002.html:18: '</div>', On 2016/09/26 at 09:13:36, Xiaocheng wrote: > ...
4 years, 2 months ago (2016-09-26 10:05:16 UTC) #9
Xiaocheng
lgtm
4 years, 2 months ago (2016-09-27 07:13:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370683002/40001
4 years, 2 months ago (2016-09-27 08:45:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-09-27 08:50:48 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 08:52:11 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24e648cb3305aa9ba91424dede65953815b76e07
Cr-Commit-Position: refs/heads/master@{#421149}

Powered by Google App Engine
This is Rietveld 408576698