third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp - Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

Issue 2370673002: Changed EDisplay to an enum class and renamed its members to be keywords (Closed)

Patch Set: Undid accidental renames Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

diff --git a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

index e2f6ae007e3a6a38b33d3252583ae931c4e665f5..9756f51c567d42043d29d931c652a1b1943196a3 100644

--- a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

+++ b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

@@ -63,7 +63,7 @@ bool isVisible(const Element& element)

if (!style)

return false;

return (

- style->display() != NONE

+ style->display() != EDisplay::None

&& style->visibility() != EVisibility::Hidden

&& style->opacity() != 0

);