Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java

Issue 2370663002: Remove logic to reset input method more than needed (Closed)
Patch Set: remove aura change Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
index 68452ed5d89f3bc263c53c0b43876a28a40f1718..2c22f76ac16461a7fdc4c6f069b745b5a79f894a 100644
--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
@@ -90,15 +90,21 @@ public class TestInputMethodManagerWrapper extends InputMethodManagerWrapper {
candidatesEnd);
Pair<Range, Range> newUpdateSelection =
new Pair<>(new Range(selStart, selEnd), new Range(candidatesStart, candidatesEnd));
+ Range lastSelection = null;
+ Range lastComposition = null;
if (!mUpdateSelectionList.isEmpty()) {
- Pair<Range, Range> lastUpdateSelection =
+ Pair<Range, Range> lastUpdateSelection = null;
+ lastUpdateSelection =
mUpdateSelectionList.get(mUpdateSelectionList.size() - 1);
if (lastUpdateSelection.equals(newUpdateSelection)) return;
+ lastSelection = lastUpdateSelection.first;
+ lastComposition = lastUpdateSelection.second;
}
mUpdateSelectionList.add(new Pair<Range, Range>(
new Range(selStart, selEnd), new Range(candidatesStart, candidatesEnd)));
mSelection.set(selStart, selEnd);
mComposition.set(candidatesStart, candidatesEnd);
+ onUpdateSelection(lastSelection, lastComposition, mSelection, mComposition);
}
@Override
@@ -162,4 +168,8 @@ public class TestInputMethodManagerWrapper extends InputMethodManagerWrapper {
public CursorAnchorInfo getLastCursorAnchorInfo() {
return mLastCursorAnchorInfo;
}
+
+ public void onUpdateSelection(Range oldSel, Range oldComp, Range newSel, Range newComp) {}
+
+ public void expectsSelectionOutsideComposition() {}
}

Powered by Google App Engine
This is Rietveld 408576698