Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2370663002: Remove logic to reset input method more than needed (Closed)
Patch Set: fixed handle issue in another CL Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index dc8800ec6cf9604b930ca65d6726958faeb6b78c..538a611263d2e62f88249952a03bd8489e6cfa7f 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -483,22 +483,6 @@ void InputMethodController::cancelComposition() {
dispatchCompositionEndEvent(frame(), emptyString);
}
-void InputMethodController::cancelCompositionIfSelectionIsInvalid() {
- if (!hasComposition() || editor().preventRevealSelection())
- return;
-
- // Check if selection start and selection end are valid.
- FrameSelection& selection = frame().selection();
- if (!selection.isNone() && !m_compositionRange->collapsed()) {
- if (selection.start().compareTo(m_compositionRange->startPosition()) >= 0 &&
- selection.end().compareTo(m_compositionRange->endPosition()) <= 0)
- return;
- }
-
- cancelComposition();
- frame().chromeClient().didCancelCompositionOnSelectionChange();
-}
-
// If current position is at grapheme boundary, return 0; otherwise, return the
// distance to its nearest left grapheme boundary.
static size_t computeDistanceToLeftGraphemeBoundary(const Position& position) {
« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.h ('k') | third_party/WebKit/Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698