Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2370663002: Remove logic to reset input method more than needed (Closed)
Patch Set: fixed handle issue in another CL Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 19c0817664cf970620c62313c1367cd116125b07..910761ef47f3c5e967e9854973470d372b4ae3ad 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -211,7 +211,6 @@ void FrameSelection::setSelectionAlgorithm(
m_handleVisibility == handleVisibility) {
// Even if selection was not changed, selection offsets may have been
// changed.
- m_frame->inputMethodController().cancelCompositionIfSelectionIsInvalid();
notifyLayoutObjectOfSelectionChange(userTriggered);
return;
}
@@ -258,10 +257,9 @@ void FrameSelection::setSelectionAlgorithm(
// boundary, selection for the DOM tree is shrunk while that for the
// flat tree is not. Additionally, this case occurs in some edge cases.
// See also: editing/pasteboard/4076267-3.html
- if (oldSelection == m_selectionEditor->visibleSelection<Strategy>()) {
- m_frame->inputMethodController().cancelCompositionIfSelectionIsInvalid();
+ if (oldSelection == m_selectionEditor->visibleSelection<Strategy>())
return;
- }
+
m_frame->editor().respondToChangedSelection(oldSelectionStart, options);
if (userTriggered == UserTriggered) {
ScrollAlignment alignment;
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/InputMethodController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698