third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2370663002: Remove logic to reset input method more than needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2370663002: Remove logic to reset input method more than needed (Closed)

Patch Set: fix test, fix IMC Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 7929d8fa3fbaa57806c46da6e1ada59c298b7280..cd1804664182ccc14c9d7d16571eedb1aeaa04f7 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -1587,8 +1587,9 @@ TEST_P(WebViewTest, SetEditableSelectionOffsetsKeepsComposition) {

EXPECT_EQ("hello world", std::string(info.value.utf8().data()));

EXPECT_EQ(2, info.selectionStart);

EXPECT_EQ(2, info.selectionEnd);

- EXPECT_EQ(-1, info.compositionStart);

- EXPECT_EQ(-1, info.compositionEnd);

+ // Composition range should be reset by browser process or keyboard apps.

+ EXPECT_EQ(6, info.compositionStart);

+ EXPECT_EQ(11, info.compositionEnd);

}

TEST_P(WebViewTest, IsSelectionAnchorFirst) {