Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2370663002: Remove logic to reset input method more than needed (Closed)
Patch Set: fix test, fix IMC Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 0238e0b185480ab4010b2ce338dc56d0336b45ea..82a4d8795fd05a07d2263bf606b2a7fd7119b6ff 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -212,7 +212,6 @@ void FrameSelection::setSelectionAlgorithm(
m_handleVisibility == handleVisibility) {
// Even if selection was not changed, selection offsets may have been
// changed.
- m_frame->inputMethodController().cancelCompositionIfSelectionIsInvalid();
notifyLayoutObjectOfSelectionChange(userTriggered);
return;
}
@@ -262,10 +261,9 @@ void FrameSelection::setSelectionAlgorithm(
// boundary, selection for the DOM tree is shrunk while that for the
// flat tree is not. Additionally, this case occurs in some edge cases.
// See also: editing/pasteboard/4076267-3.html
- if (oldSelection == m_selectionEditor->visibleSelection<Strategy>()) {
- m_frame->inputMethodController().cancelCompositionIfSelectionIsInvalid();
+ if (oldSelection == m_selectionEditor->visibleSelection<Strategy>())
return;
- }
+
m_frame->editor().respondToChangedSelection(oldSelectionStart, options);
if (userTriggered == UserTriggered) {
ScrollAlignment alignment;

Powered by Google App Engine
This is Rietveld 408576698