Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2370663002: Remove logic to reset input method more than needed (Closed)
Patch Set: fixed handle issue in another CL Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1049 matching lines...) Expand 10 before | Expand all | Expand 10 after
1060 if (WebViewClient* client = m_webView->client()) 1060 if (WebViewClient* client = m_webView->client())
1061 client->draggableRegionsChanged(); 1061 client->draggableRegionsChanged();
1062 } 1062 }
1063 1063
1064 void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) { 1064 void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) {
1065 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame); 1065 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);
1066 if (webframe->autofillClient()) 1066 if (webframe->autofillClient())
1067 webframe->autofillClient()->didAssociateFormControlsDynamically(); 1067 webframe->autofillClient()->didAssociateFormControlsDynamically();
1068 } 1068 }
1069 1069
1070 void ChromeClientImpl::didCancelCompositionOnSelectionChange() {
1071 if (m_webView->client())
1072 m_webView->client()->didCancelCompositionOnSelectionChange();
1073 }
1074
1075 void ChromeClientImpl::resetInputMethod() { 1070 void ChromeClientImpl::resetInputMethod() {
1076 if (m_webView->client()) 1071 if (m_webView->client())
1077 m_webView->client()->resetInputMethod(); 1072 m_webView->client()->resetInputMethod();
1078 } 1073 }
1079 1074
1080 void ChromeClientImpl::showVirtualKeyboardOnElementFocus() { 1075 void ChromeClientImpl::showVirtualKeyboardOnElementFocus() {
1081 if (m_webView->client()) 1076 if (m_webView->client())
1082 m_webView->client()->showVirtualKeyboardOnElementFocus(); 1077 m_webView->client()->showVirtualKeyboardOnElementFocus();
1083 } 1078 }
1084 1079
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
1219 PresentationController::provideTo(frame, client->presentationClient()); 1214 PresentationController::provideTo(frame, client->presentationClient());
1220 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1215 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1221 provideAudioOutputDeviceClientTo(frame, 1216 provideAudioOutputDeviceClientTo(frame,
1222 new AudioOutputDeviceClientImpl(frame)); 1217 new AudioOutputDeviceClientImpl(frame));
1223 } 1218 }
1224 if (RuntimeEnabledFeatures::installedAppEnabled()) 1219 if (RuntimeEnabledFeatures::installedAppEnabled())
1225 InstalledAppController::provideTo(frame, client->installedAppClient()); 1220 InstalledAppController::provideTo(frame, client->installedAppClient());
1226 } 1221 }
1227 1222
1228 } // namespace blink 1223 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698