Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2370663002: Remove logic to reset input method more than needed (Closed)
Patch Set: fix test, fix IMC Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 995 matching lines...) Expand 10 before | Expand all | Expand 10 after
1006 if (WebViewClient* client = m_webView->client()) 1006 if (WebViewClient* client = m_webView->client())
1007 client->draggableRegionsChanged(); 1007 client->draggableRegionsChanged();
1008 } 1008 }
1009 1009
1010 void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) { 1010 void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) {
1011 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame); 1011 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);
1012 if (webframe->autofillClient()) 1012 if (webframe->autofillClient())
1013 webframe->autofillClient()->didAssociateFormControlsDynamically(); 1013 webframe->autofillClient()->didAssociateFormControlsDynamically();
1014 } 1014 }
1015 1015
1016 void ChromeClientImpl::didCancelCompositionOnSelectionChange() {
1017 if (m_webView->client())
1018 m_webView->client()->didCancelCompositionOnSelectionChange();
1019 }
1020
1021 void ChromeClientImpl::resetInputMethod() { 1016 void ChromeClientImpl::resetInputMethod() {
1022 if (m_webView->client()) 1017 if (m_webView->client())
1023 m_webView->client()->resetInputMethod(); 1018 m_webView->client()->resetInputMethod();
1024 } 1019 }
1025 1020
1026 void ChromeClientImpl::showVirtualKeyboard() { 1021 void ChromeClientImpl::showVirtualKeyboard() {
1027 if (m_webView->client()) 1022 if (m_webView->client())
1028 m_webView->client()->showVirtualKeyboard(); 1023 m_webView->client()->showVirtualKeyboard();
1029 } 1024 }
1030 1025
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1166 PresentationController::provideTo(frame, client->presentationClient()); 1161 PresentationController::provideTo(frame, client->presentationClient());
1167 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1162 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1168 provideAudioOutputDeviceClientTo(frame, 1163 provideAudioOutputDeviceClientTo(frame,
1169 new AudioOutputDeviceClientImpl(frame)); 1164 new AudioOutputDeviceClientImpl(frame));
1170 } 1165 }
1171 if (RuntimeEnabledFeatures::installedAppEnabled()) 1166 if (RuntimeEnabledFeatures::installedAppEnabled())
1172 InstalledAppController::provideTo(frame, client->installedAppClient()); 1167 InstalledAppController::provideTo(frame, client->installedAppClient());
1173 } 1168 }
1174 1169
1175 } // namespace blink 1170 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698