Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2370653002: MD WebUI: Remove <style no-process> from Polymer (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Remove <style no-process> from Polymer <style no-process> was added in crrev.com/391871 as a temporary measure to allow native custom properties to be used without being overridden by Polymer's shim. All Polymer pages now use native custom properties, so this bypass is no longer necessary. This CL removes it from our Polymer checkout and the MD History/Downloads pages, with no visible changes as a result. BUG=608098 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b8534fb568a8450d5a52589a73343735709d17cd Cr-Commit-Position: refs/heads/master@{#421119}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -31 lines) Patch
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +0 lines, -5 lines 2 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.html View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/chromium.patch View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-extracted.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
tsergeant
4 years, 2 months ago (2016-09-26 03:11:14 UTC) #6
tsergeant
PTAL!
4 years, 2 months ago (2016-09-26 03:16:42 UTC) #7
Dan Beam
generally lg (yay, kill the forks with fire) but maybe it's time to inline .css ...
4 years, 2 months ago (2016-09-26 07:08:10 UTC) #10
tsergeant
Bug filed for css migration: https://crbug.com/650504 https://codereview.chromium.org/2370653002/diff/1/chrome/browser/resources/md_downloads/manager.html File chrome/browser/resources/md_downloads/manager.html (right): https://codereview.chromium.org/2370653002/diff/1/chrome/browser/resources/md_downloads/manager.html#newcode33 chrome/browser/resources/md_downloads/manager.html:33: <link rel="import" type="css" ...
4 years, 2 months ago (2016-09-27 00:25:37 UTC) #11
Dan Beam
yeah, you're right: the vulcanized build doesn't care lgtm
4 years, 2 months ago (2016-09-27 00:37:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370653002/1
4 years, 2 months ago (2016-09-27 00:46:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148635)
4 years, 2 months ago (2016-09-27 04:40:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370653002/1
4 years, 2 months ago (2016-09-27 04:50:29 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 05:51:15 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 05:55:05 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8534fb568a8450d5a52589a73343735709d17cd
Cr-Commit-Position: refs/heads/master@{#421119}

Powered by Google App Engine
This is Rietveld 408576698