extensions/browser/value_store/leveldb_value_store.cc - Issue 2370633002: replace deprecated version of SetWithoutPathExpansion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/value_store/leveldb_value_store.cc

Issue 2370633002: replace deprecated version of SetWithoutPathExpansion (Closed)

Patch Set: use MakeUnique Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/value_store/leveldb_value_store.cc

diff --git a/extensions/browser/value_store/leveldb_value_store.cc b/extensions/browser/value_store/leveldb_value_store.cc

index 7e8779ae232d99fb6b0866f743bf961b8b2c151a..630eb6a06019c8759e787424e7cfef74eddec345 100644

--- a/extensions/browser/value_store/leveldb_value_store.cc

+++ b/extensions/browser/value_store/leveldb_value_store.cc

@@ -88,7 +88,7 @@ ValueStore::ReadResult LeveldbValueStore::Get(

if (!status.ok())

return MakeReadResult(status);

if (setting)

- settings->SetWithoutPathExpansion(key, setting.release());

+ settings->SetWithoutPathExpansion(key, std::move(setting));

}

return MakeReadResult(std::move(settings), status);