extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc - Issue 2370633002: replace deprecated version of SetWithoutPathExpansion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2370633002: replace deprecated version of SetWithoutPathExpansion (Closed)

Patch Set: use MakeUnique Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

index 905bb2a17f8ab5092af8a16b87e79a5ebebd96b0..5527cd61c37250f1738a33556ed9f0b3a4dfb95b 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

@@ -392,7 +392,7 @@ std::unique_ptr<base::DictionaryValue> GetDictionaryFromArray(

dictionary->RemoveWithoutPathExpansion(*name, &entry_owned);

list->Append(std::move(entry_owned));

list->AppendString(*value);

- dictionary->SetWithoutPathExpansion(*name, list);

+ dictionary->SetWithoutPathExpansion(*name, base::WrapUnique(list));

break;

case base::Value::TYPE_LIST: // Just append to the list.

CHECK(entry->GetAsList(&list));

« no previous file with comments | « no previous file | extensions/browser/api/web_request/upload_data_presenter.cc » ('j') | no next file with comments »